Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZAP Error Fixes - Define CSP #543

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

ZAP Error Fixes - Define CSP #543

wants to merge 12 commits into from

Conversation

CurtisUnderwood
Copy link
Contributor

@CurtisUnderwood CurtisUnderwood commented Aug 16, 2022 •
edited
Loading

Description of Changes

ADO Work Item XXX

What to test for/How to test

  • This PR defines our Content Security Policy and uses a nOnce to enforce a strict script policy
  • Should resolve some of our ZAP issues around missing CSP

Additional Notes

  • This may need to be revisited

Checklist

  • Tests added for key features and bugs
  • Deployment working

@CurtisUnderwood CurtisUnderwood requested a review from a team as a code owner August 16, 2022 15:36
@github-actions
Copy link

Integration Deployment 🚀 - Check build status
Jest Coverage Report GitHub Workflow Status
Cypress Coverage Report GitHub Workflow Status

@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2022

This pull request introduces 1 alert when merging a2fbe01 into 36e5b4d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2022

This pull request introduces 1 alert when merging 5aeefef into 36e5b4d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

s-laugh
s-laugh reviewed Aug 17, 2022
View reviewed changes
__tests__/pages/_document.test.js Outdated Show resolved Hide resolved
__tests__/pages/_document.test.js Outdated Show resolved Hide resolved
lib/Utils.js Outdated Show resolved Hide resolved
pages/_document.js Outdated Show resolved Hide resolved
nibivi77
nibivi77 reviewed Aug 17, 2022
View reviewed changes
pages/_document.js Outdated Show resolved Hide resolved
DaceyTom2
DaceyTom2 reviewed Aug 18, 2022
View reviewed changes
pages/_document.js Outdated Show resolved Hide resolved
s-laugh
s-laugh reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@s-laugh s-laugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional comments from me. But agree with the others raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibivi77 nibivi77 nibivi77 left review comments

@s-laugh s-laugh s-laugh left review comments

@DaceyTom2 DaceyTom2 Awaiting requested review from DaceyTom2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CurtisUnderwood @s-laugh @DaceyTom2 @nibivi77